[Backport 2.x] Change INDEX_SEARCHER threadpool to auto queue to support task resource tracking #7765
+390
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
…ort task resource tracking (opensearch-project#7502) (cherry picked from commit 054cccd) Signed-off-by: Jay Deng <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
jed326
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
dbwiddis
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #7765 +/- ##
============================================
- Coverage 70.56% 70.53% -0.03%
+ Complexity 56409 56372 -37
============================================
Files 4665 4665
Lines 267683 267683
Branches 39638 39638
============================================
- Hits 188885 188810 -75
- Misses 62512 62607 +95
+ Partials 16286 16266 -20
|
|
Flaky test looks like #6761 |
reta
approved these changes
May 25, 2023
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…ort task resource tracking (opensearch-project#7502) (opensearch-project#7765) (cherry picked from commit 054cccd) Signed-off-by: Jay Deng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backports #7502
Concurrent segment search has been backported to 2.x so we also need to backport #7502 so that we are not missing out on resource tracking whenever concurrent search is GA.
Since
Resizablethreadpool type does not exist in 2.x, we will use the same auto queue threadpool type that search threadpool uses in 2.x.Ref #7613
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Resolves #7743